Replace dependency management plugin with Gradle platform dependencies #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=========================================
Coverage 91.83% 91.83%
Complexity 1202 1202
=========================================
Files 146 146
Lines 2904 2904
Branches 294 294
=========================================
Hits 2667 2667
Misses 176 176
Partials 61 61 Continue to review full report at Codecov.
|
royclarkson
force-pushed
the
gradle-platform-dependencies
branch
from
979fe76 to
99b4141
Compare
royclarkson
force-pushed
the
gradle-platform-dependencies
branch
from
99b4141 to
6126273
Compare
dyroberts
approved these changes
Jun 25, 2020
| @@ -18,12 +18,14 @@ import org.springframework.cloud.contract.verifier.config.TestFramework | |||
|
|
|||
| buildscript { | |||
| dependencies { | |||
| classpath("io.spring.gradle:dependency-management-plugin:1.0.9.RELEASE") | |||
There was a problem hiding this comment.
Just curious, why use the dm plugin here?
There was a problem hiding this comment.
Spring Cloud Contract seems to have some dependency on the DM plugin. When I tried to use the platform dependency, the submodule would not build. Considering this is only for tests and we aren't publishing this module, I decided to leave it alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.